yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

PR24355, segmentation fault in function called from ppc_finish_symbols

Browse Source 
This one looks to be a bug going back to 2009, git commit e054468f6c
"STT_GNU_IFUNC support for PowerPC".  That bug was carried over with
git commit 49c09209d0 "Rearrange PLT reloc output on powerpc".

If the refcount for an ifunc local sym plt entry was zero,
ppc_elf_size_dynamic_sections would correctly set plt.offset to -1 but
leave glink_offset uninitialized.  That leads to occasional segfaults
(which can be made solid with MALLOC_PERTURB_=1 when using glibc).
So, guard the write_glink_stub call with plt.offset != -1.  Also,
remove the totally ineffective attempt at writing multiple-use glink
stubs only once.

	PR 24355
	* elf32-ppc.c (ppc_finish_symbols): Don't call write_glink_stub
	for local iplt syms with ent->plt.offset == -1.  Remove ineffective
	attempt at writing glink stubs only once.
This commit is contained in:
Alan Modra
2019-03-18 21:38:36 +10:30
parent 28a66f07f0
commit 8cd1fe1bf5
2 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bfd/ChangeLog
+7
View File
@@ -1,3 +1,10 @@
2019-03-18 Alan Modra <amodra@gmail.com>
PR 24355
* elf32-ppc.c (ppc_finish_symbols): Don't call write_glink_stub
for local iplt syms with ent->plt.offset == -1. Remove ineffective
attempt at writing glink stubs only once.
2019-03-16 Alan Modra <amodra@gmail.com>
PR 24337
bfd/elf32-ppc.c
+2 -6
View File
@@ -9704,6 +9704,7 @@ ppc_finish_symbols (struct bfd_link_info *info)
bfd_byte *loc;
bfd_vma val;
Elf_Internal_Rela rela;
unsigned char *p;
if (!get_sym_h (NULL, &sym, &sym_sec, NULL, &local_syms,
lplt - local_plt, ibfd))
@@ -9748,14 +9749,9 @@ ppc_finish_symbols (struct bfd_link_info *info)
loc = relplt->contents + (relplt->reloc_count++
* sizeof (Elf32_External_Rela));
bfd_elf32_swap_reloca_out (info->output_bfd, &rela, loc);
}
if ((ent->glink_offset & 1) == 0)
{
unsigned char *p = ((unsigned char *) htab->glink->contents
+ ent->glink_offset);
p = (unsigned char *) htab->glink->contents + ent->glink_offset;
write_glink_stub (NULL, ent, htab->elf.iplt, p, info);
ent->glink_offset |= 1;
}
}