yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

x86: flag EVEX.z set when destination is a mask register

Browse Source 
While only zeroing-masking is possible in this case, this still requires
EVEX.z to be clear. Introduce a "global" flag right here, to be re-used
by checks which need to live in specific operand handlers.
This commit is contained in:
Jan Beulich
2023-07-04 17:00:35 +02:00
parent 07d618b91f
commit ac500f1772
3 changed files with 16 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
gas/testsuite/gas/i386/avx512f-nondef.d
+1
View File
@@ -20,4 +20,5 @@ Disassembly of section .text:
[ ]*[a-f0-9]+: 67 62 f2 7d 4f 92 01 addr16 vgatherdps \(bad\),%zmm0\{%k7\}
[ ]*[a-f0-9]+: 62 f2 7d cf 92 04 08 vgatherdps \(%eax,%zmm1(,1)?\),%zmm0\{%k7\}\{z\}/\(bad\)
[ ]*[a-f0-9]+: 62 f2 7d 48 92 04 08 vgatherdps \(%eax,%zmm1(,1)?\),%zmm0/\(bad\)
[ ]*[a-f0-9]+: 62 f1 7c cf c2 c0 00 vcmpeqps %zmm0,%zmm0,%k0\{%k7\}\{z\}/\(bad\)
#pass
gas/testsuite/gas/i386/avx512f-nondef.s
+3
View File
@@ -26,3 +26,6 @@
.insn EVEX.66.0F38.W0 0x92, (%eax,%zmm1), %zmm0{%k7}{z}
# vgatherdps (%eax,%zmm1), %zmm0 # without actual mask register
.insn EVEX.66.0F38.W0 0x92, (%eax,%zmm1), %zmm0
# vcmpeqps %zmm0, %zmm0, %k0{%k7} with EVEX.z set
.insn EVEX.0f 0xc2, $0, %zmm0, %zmm0, %k0{%k7}{z}
opcodes/i386-dis.c
+12
View File
@@ -219,6 +219,9 @@ struct instr_info
bool two_source_ops;
/* Record whether EVEX masking is used incorrectly. */
bool illegal_masking;
unsigned char op_ad;
signed char op_index[MAX_OPERANDS];
bool op_riprel[MAX_OPERANDS];
@@ -9915,12 +9918,21 @@ print_insn (bfd_vma pc, disassemble_info *info, int intel_syntax)
continue;
}
/* Instructions with a mask register destination allow for
zeroing-masking only (if any masking at all), which is
_not_ expressed by EVEX.z. */
if (ins.vex.zeroing && dp->op[0].bytemode == mask_mode)
ins.illegal_masking = true;
/* S/G insns require a mask and don't allow
zeroing-masking. */
if ((dp->op[0].bytemode == vex_vsib_d_w_dq_mode
|| dp->op[0].bytemode == vex_vsib_q_w_dq_mode)
&& (ins.vex.mask_register_specifier == 0
|| ins.vex.zeroing))
ins.illegal_masking = true;
if (ins.illegal_masking)
oappend (&ins, "/(bad)");
}
}