yggdrasil/binutils-gdb
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove coff_pointerize_aux table_end param

Browse Source 
I'm fairly certain the table_end checks are redundant now.  This
patch reverts commit 334d4ced42.

	* coffgen.c (coff_pointerize_aux): Remove table_end parameter.
	(coff_get_normalized_symtab): Adjust to suit.
This commit is contained in:
Alan Modra
2023-03-27 16:45:57 +10:30
parent a2c7ca15a5
commit f00a29e30b
1 changed files with 4 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
bfd/coffgen.c
+4 -9
View File
@@ -1434,8 +1434,7 @@ coff_pointerize_aux (bfd *abfd,
combined_entry_type *table_base,
combined_entry_type *symbol,
unsigned int indaux,
combined_entry_type *auxent,
combined_entry_type *table_end)
combined_entry_type *auxent)
{
unsigned int type = symbol->u.syment.n_type;
unsigned int n_sclass = symbol->u.syment.n_sclass;
@@ -1465,9 +1464,7 @@ coff_pointerize_aux (bfd *abfd,
|| n_sclass == C_FCN)
&& auxent->u.auxent.x_sym.x_fcnary.x_fcn.x_endndx.u32 > 0
&& (auxent->u.auxent.x_sym.x_fcnary.x_fcn.x_endndx.u32
< obj_raw_syment_count (abfd))
&& (table_base + auxent->u.auxent.x_sym.x_fcnary.x_fcn.x_endndx.u32
< table_end))
< obj_raw_syment_count (abfd)))
{
auxent->u.auxent.x_sym.x_fcnary.x_fcn.x_endndx.p =
table_base + auxent->u.auxent.x_sym.x_fcnary.x_fcn.x_endndx.u32;
@@ -1476,8 +1473,7 @@ coff_pointerize_aux (bfd *abfd,
/* A negative tagndx is meaningless, but the SCO 3.2v4 cc can
generate one, so we must be careful to ignore it. */
if (auxent->u.auxent.x_sym.x_tagndx.u32 < obj_raw_syment_count (abfd)
&& table_base + auxent->u.auxent.x_sym.x_tagndx.u32 < table_end)
if (auxent->u.auxent.x_sym.x_tagndx.u32 < obj_raw_syment_count (abfd))
{
auxent->u.auxent.x_sym.x_tagndx.p =
table_base + auxent->u.auxent.x_sym.x_tagndx.u32;
@@ -1768,8 +1764,7 @@ coff_get_normalized_symtab (bfd *abfd)
&(internal_ptr->u.auxent));
internal_ptr->is_sym = false;
coff_pointerize_aux (abfd, internal, symbol_ptr, i,
internal_ptr, internal_end);
coff_pointerize_aux (abfd, internal, symbol_ptr, i, internal_ptr);
}
}