Commit 667de09279
broke CI by adding rust-toolchain.toml, which changed
the default rust version to nightly.
Explicitly specify the rust version in CI to use the correct
toolchain.
the semver checks action and the release action are not
in the allow-list so replace them with their respective
cli counterparts.
These changes can only be tested by someone with permissions,
so the release part only releases a draft release for now.
When specifying `cbindgen` as a dependency via git, several 'skipping duplicate
package' warnings pop up regarding some of the test crates.
The warning seems to be spurious given that the test packages aren't needed when
depending on `cbindgen` (see https://github.com/rust-lang/cargo/issues/10752),
but while a fix is being considered for Cargo, this commit disambiguates the
duplicated package names by referring to their relative paths.
Previously config files next to an explicit input file
could not be picked up, since the `from_root_or_default`
functions assumes the input path is a directory.
This is the case for all other usages of the function, but
in this case we know the input is a file, so we determine
the parent directory and look for the config file in that
directory. There can't be a folder with the same name
as the input file, so it's not possible that we won't
pick up any files anymore that we previously did.
Add an option to output a depfile for outside build-systems to learn
the source file dependencies of the bindings.
This can be used by 3rd party build system integrations to only rerun
bindgen when necessary.
Testing is done via CMake integration tests, since CMake
is a 3rd party buildsystem which supports depfiles.
Since our MSRV is now Rust 1.54, we can rely on cargo setting `CARGO_BIN_EXE_cbindgen`
to the cbindgen path in integration tests.
This is more reliable than guessing the path, since cargo knows where it placed the bin.
Fixes the following warning:
> Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions/checkout@v2, actions-rs/cargo@v1, actions-rs/toolchain@v1. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.
Steps:
- upgrade checkout to v3
- Replace the actions-rs/cargo action, by simply calling cargo from the commandline.
I don't see why one would want to involve a node.js action there in the first place.
- Replace the actions-rs/toolchain with dtolnays version, which uses the shell instead
of node.js
Instead of two steps installing the toolchain, do it one step.
Removes the unmaintained action-rs/toolchain action.
Installs stable clippy instead of nightly clippy.
The current implementation never goes to a new line when writing a
function pointer type, this can lead to long, difficult to read lines.
The goal of this change is to make that a bit more sensible.
Here is a rust code example
```
1 │ pub type MyCallback = Option<unsafe extern "C" fn(a: usize, b: usize)>;
2 │
3 │ pub type MyOtherCallback =
4 │ Option<unsafe extern "C" fn(a: usize, lot: usize, of: usize, args: usize)>;
5 │
6 │ #[no_mangle]
7 │ pub extern "C" fn my_function(a: MyCallback, b: MyOtherCallback) {}
```
right when generating the corresponing C header we get
```
1 │ #include <stdarg.h>
2 │ #include <stdbool.h>
3 │ #include <stdint.h>
4 │ #include <stdlib.h>
5 │
6 │ typedef void (*MyCallback)(uintptr_t a, uintptr_t b);
7 │
8 │ typedef void (*MyOtherCallback)(uintptr_t a, uintptr_t lot, uintptr_t of, uintptr_t args);
9 │
10 │ void my_function(MyCallback a, MyOtherCallback b);
```
line 8 here is already quite long and will be even longer if we add new
args to `MyOtherCallback`
With the changes in this commit, we now get
```
1 │ #include <stdarg.h>
2 │ #include <stdbool.h>
3 │ #include <stdint.h>
4 │ #include <stdlib.h>
5 │
6 │ typedef void (*MyCallback)(uintptr_t a, uintptr_t b);
7 │
8 │ typedef void (*MyOtherCallback)(uintptr_t a,
9 │ uintptr_t lot,
10 │ uintptr_t of,
11 │ uintptr_t args);
12 │
13 │ void my_function(MyCallback a, MyOtherCallback b);
```
which is way better and more scalable if new args are atted to
`MyOtherCallback`
The behavior is configurable using the already existing `fn.args`
configuration parameter. In this case setting it to `Horizontal` gives
back the same .h as previously and setting it to `Vertical` makes the
generator go to a new line even for the shorter `MyCallback`
declaration:
```
1 │ #include <stdarg.h>
2 │ #include <stdbool.h>
3 │ #include <stdint.h>
4 │ #include <stdlib.h>
5 │
6 │ typedef void (*MyCallback)(uintptr_t a,
7 │ uintptr_t b);
8 │
9 │ typedef void (*MyOtherCallback)(uintptr_t a,
10 │ uintptr_t lot,
11 │ uintptr_t of,
12 │ uintptr_t args);
13 │
14 │ void my_function(MyCallback a,
15 │ MyOtherCallback b);
```
Closes#793
Jonathan Schwender
boxdot
sevenc-nanashi
Emilio Cobos Álvarez
Ian Hobson
Sjors Holtrop
Jonathan Schwender
Owen Phillips
Wei Zhang
Alex Touchet
Romain Malmain
Thibaut Lorrain
novafacing
messense
Andrew Kane