yggdrasil/gcc
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Explicitly view_convert_expr mask to signed type when folding pblendvb builtins.

Browse Source 
Since mask < 0 will be always false for vector char when
-funsigned-char, but vpblendvb needs to check the most significant
bit. The patch explicitly VCE to vector signed char.

gcc/ChangeLog:

	PR target/110108
	* config/i386/i386.cc (ix86_gimple_fold_builtin): Explicitly
	view_convert_expr mask to signed type when folding pblendvb
	builtins.

gcc/testsuite/ChangeLog:

	* gcc.target/i386/pr110108-2.c: New test.
This commit is contained in:
liuhongt
2023-06-05 12:38:41 +08:00
parent b91956fc7d
commit 5e01a590aa
2 changed files with 17 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
gcc/config/i386/i386.cc
+3 -1
View File
@@ -18537,8 +18537,10 @@ ix86_gimple_fold_builtin (gimple_stmt_iterator *gsi)
tree itype = GET_MODE_INNER (TYPE_MODE (type)) == E_SFmode
? intSI_type_node : intDI_type_node;
type = get_same_sized_vectype (itype, type);
arg2 = gimple_build (&stmts, VIEW_CONVERT_EXPR, type, arg2);
}
else
type = signed_type_for (type);
arg2 = gimple_build (&stmts, VIEW_CONVERT_EXPR, type, arg2);
tree zero_vec = build_zero_cst (type);
tree cmp_type = truth_type_for (type);
tree cmp = gimple_build (&stmts, LT_EXPR, cmp_type, arg2, zero_vec);
gcc/testsuite/gcc.target/i386/pr110108-2.c
+14
View File
@@ -0,0 +1,14 @@
/* { dg-do compile } */
/* { dg-options "-mavx2 -O2 -funsigned-char" } */
/* { dg-final { scan-assembler-times "vpblendvb" 2 } } */
#include <immintrin.h>
__m128i do_stuff_128(__m128i X0, __m128i X1, __m128i X2) {
__m128i Result = _mm_blendv_epi8(X0, X1, X2);
return Result;
}
__m256i do_stuff_256(__m256i X0, __m256i X1, __m256i X2) {
__m256i Result = _mm256_blendv_epi8(X0, X1, X2);
return Result;
}