Brian Smith
fb9931b576
Add note about casting to STYLE.md.
2016-02-22 10:13:13 -10:00
Brian Smith
063985413e
Add notes about unsafe
to the style guide.
2016-02-22 10:12:49 -10:00
Brian Smith
ba126545ca
Use x[..n]
instead of x[0..n]
.
...
Also, update the style guide.
2016-02-22 09:26:44 -10:00
Corey Farwell
908161a824
Remove unnecessary lower bound when slicing in digest.
...
At this point in the function, `num_pending` is always 0.
I agree to license my contributions to each file under the
same terms given at the top of each file I changed.
2016-02-22 07:17:32 -10:00
Brian Smith
fd6765735b
Add non-zero in_prefix_len
tests for aead::open_in_place
.
2016-02-22 00:04:52 -10:00
Brian Smith
d62d3cd3bd
Clarify CLA-related stuff in README.md.
2016-02-21 22:55:16 -10:00
Corey Farwell
fcefa13b51
Fix invalid syntax for inline code within doc comment.
...
I agree to license my contributions to each file under the
same terms given at the top of each file I changed.
2016-02-21 22:35:07 -10:00
Corey Farwell
7912df5150
Utilize polyfill utility instead of manual fill.
...
I agree to license my contributions to each file under the
same terms given at the top of each file I changed.
2016-02-16 11:18:07 -10:00
Brian Smith
d0b98239ec
Use |const AES_KEY *| instead of |const void *| in GCM code.
2016-02-16 11:16:51 -10:00
Brian Smith
80400f5fdf
Use |plaintext_len| instead of recalculating it.
2016-02-16 11:16:29 -10:00
Brian Smith
b713290336
Remove reference counting code.
...
Rust programs can use Rust's `Rc` or other mechanisms for reference
counting and non-Rust code can do similar.
2016-02-14 16:05:00 -10:00
Brian Smith
d69d04d2cf
Inline |CRYPTO_gcm128_finish| into |CRYPTO_gcm128_tag|.
...
|CRYPTO_gcm128_tag| always passes NULL to |CRYPTO_gcm128_finish| so the
tag verification logic in |CRYPTO_gcm128_finish| is dead code.
|CRYPTO_gcm128_tag| is the only caller, so |CRYPTO_gcm128_finish|
doesn't need to exist as a separate function any more.
Eventually the |CRYPTO_memcmp| code will get
2016-02-14 15:55:17 -10:00
Brian Smith
e35091e5cc
Remove unused |CRYPTO_gcm128_new| and |CRYPTO_gcm128_release|.
2016-02-14 15:55:16 -10:00
Brian Smith
3e47fea7ca
Remove gcm_test.
...
All the test cases in gcm_test (except the AES-192 test vectors we
don't care about) are already tested in the AEAD tests; i.e.
aes_128_gcm_tests.txt and aes_256_gcm_tests.txt already contain all
the test vectors in gcm_test.c.
2016-02-14 15:55:16 -10:00
Brian Smith
08f0f208f9
Revert unnecessary #pragma warning in file_test.h.
2016-02-14 14:55:51 -10:00
Brian Smith
c5d4df21e5
Enable MSVC C4710: 'function' : function not inlined.
2016-02-14 14:51:58 -10:00
Brian Smith
cb53600ec1
Document which MSVC warnings should be re-enabled.
2016-02-14 14:30:52 -10:00
Brian Smith
be71db10b9
Enable C/C++ unused parameter warnings.
2016-02-14 13:55:48 -10:00
Brian Smith
3475ed9e61
Remove unused parameters in Windows/OPENSSL_NO_ASM code.
2016-02-14 13:55:48 -10:00
Brian Smith
8435da899b
Remove unused parameters in tests.
2016-02-14 13:55:47 -10:00
Brian Smith
f9db33d0f4
Remove unused parameters in crypto/ec functions.
2016-02-14 13:55:47 -10:00
Brian Smith
2fe69349d9
Suppress unused parameter warnings in crypto/cipher/internal.h.
2016-02-14 13:55:47 -10:00
Brian Smith
7ec7a70e14
Enable more compiler warnings.
2016-02-14 13:55:46 -10:00
Brian Smith
9ef108a55e
Enable more C/C++ compiler warnings.
2016-02-14 13:01:39 -10:00
Brian Smith
844b9f2e5c
Remove unused |ctx| parameter from |BN_generate_dsa_nonce|.
2016-02-14 13:01:38 -10:00
Brian Smith
16fe6c86d3
Make chacha_vec.c -Wundef clean.
2016-02-14 12:57:21 -10:00
Brian Smith
8042ee85f2
Simplify |aes_ctr_set_key|.
...
Remove the unused |out_block| parameter and assume |gcm_ctx| is not
NULL.
2016-02-14 11:10:23 -10:00
Brian Smith
5c2c995d04
Remove unneeded function pointer casts in AES-GCM code.
2016-02-14 11:10:23 -10:00
Brian Smith
00830b53fd
Use a more idomatic approach to overflow checking in ring::input
.
2016-02-14 07:51:06 -10:00
Pyfisch
92806f9178
Remove rsa_get_public_exp
in blinding.c.
...
Instead, just fail if `rsa->e` is `NULL`.
I agree to license my contributions to each file under the
same terms given at the top of each file I changed.
2016-02-13 15:50:24 -10:00
Corey Farwell
b95fd0986a
Utilize polyfill utility instead of manual fill.
...
I agree to license my contributions to each file under the
same terms given at the top of each file I changed.
2016-02-13 15:46:39 -10:00
Brian Smith
7cfe90fc2b
Don't cast |OPENSSL_malloc| result.
...
C has implicit conversion of |void *| to other pointer types so these
casts are unnecessary. Clean them up to make the code easier to read
and to make it easier to find dangerous casts.
2016-02-09 18:56:58 -10:00
Brian Smith
b8c896b6ef
Remove casts from |size_t| to |unsigned| in RSA padding code.
2016-02-09 18:49:38 -10:00
Brian Smith
d617f2ff61
Merge BoringSSL 642b0b8: Remove unused bits of RSA blinding code.
...
This was done earlier in *ring*, but the earlier *ring* change missed
the removal of the declarations in the header file.
2016-02-09 18:37:11 -10:00
Brian Smith
4c995491e9
Take BoringSSL a051bdd: Remove dead non-|BN_ULLONG|, non-64-bit-MSVC code in crypto/bn.
2016-02-09 18:35:47 -10:00
Brian Smith
a1109881c1
Take BoringSSL 767e121: Remove unused Simics code in crypto/bn/asm/x86_64-gcc.c.
2016-02-09 18:35:27 -10:00
Brian Smith
b551fff7ee
No-op merge of BoringSSL b121a26: Remove unused |ec_GFp_simple_group_check_discriminant|.
...
This was removed a long time ago in *ring*.
2016-02-09 18:34:46 -10:00
Brian Smith
bff5d3c774
Merge BoringSSL 4862b3b: Remove useless and out-of-date comments in crypto/ec/internal.h.
2016-02-09 18:34:16 -10:00
Brian Smith
625e3d8198
No-op merge of BoringSSL fce7604: Remove duplicative ECC |group_init| and |group_set_curve| methods.
...
This is a subset of other changes that were already done in *ring*.
2016-02-09 18:30:13 -10:00
Brian Smith
89c39b0863
Merge BoringSSL aadf1ee: Minimize the scope of the |BN_*_SIZE_*| constants.
2016-02-09 18:29:00 -10:00
Brian Smith
651b5d5806
Take BoringSSL 8c5ea13: Remove unused |bn_mul_low_normal| and related #defines.
2016-02-09 18:27:57 -10:00
Brian Smith
f38a8588bc
Ignore BoringSSL 2c71ce1.
...
This was a change to the BoringSSL build documentation, which isn't
relevant to *ring*.
2016-02-09 18:27:28 -10:00
Brian Smith
cc82cc1be3
Ignore BoringSSL 089cba0 and 6b34d54.
...
These were changes to the BoringSSL build system, which *ring* doesn't
use.
2016-02-09 18:26:06 -10:00
Brian Smith
bd3f926236
Merge BoringSSL f98be21: Remove dead platform-specific code in |BN_div|.
2016-02-09 18:25:36 -10:00
Brian Smith
98c95a9f6c
Ignore BoringSSL fcde5aa and a37fc70.
...
These were no-op changes.
2016-02-09 18:24:02 -10:00
Brian Smith
8e6c41c9c6
Merge BoringSSL 926f219: Enable MSVC 128-bit multiplication regardless of OPENSSL_NO_ASM.
2016-02-09 18:23:32 -10:00
Brian Smith
cb8a47a394
Ignore BoringSSL 11aac10.
...
The BER parsing code isn't in *ring* any more.
2016-02-09 18:21:43 -10:00
Brian Smith
574d8214d5
Merge BoringSSL 168297e: Test |ECDSA_SIG_to_bytes| using the P-521 order size, not 512-bits.
...
The slight refactoring of the code was taken.
2016-02-09 18:20:39 -10:00
Brian Smith
a99834c547
Ignore BoringSSL 4aafe6a..d057454.
2016-02-09 18:14:21 -10:00
Brian Smith
619b4e917a
Take BoringSSL bf3335c: Add #ifdef guards to crypto/curve25519 assembly files.
2016-02-09 18:06:00 -10:00